Include data kwarg in pyi stubs#25632
Merged
tacaswell merged 2 commits intomatplotlib:mainfrom May 1, 2023
Merged
Conversation
Allows for stubtest to check the consistency of many prominent user facing methods Currently no type hint is provided for data, a follow up issue will be filed detailing what needs to happen to make that have a useful type hint.
Member
Author
|
Gentle nudge on this one, it should be relatively non-controversial I think, just ensuring that |
timhoffm
approved these changes
May 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Allows for
stubtestto check the consistency of many prominent user facing methodsCurrently no type hint is provided for
data, a follow up issue will be filed detailing what needs to happen to make that have a useful type hint.PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst