Remove nonfunctional Axes3D.set_frame_on and get_frame_on methods.#25648
Remove nonfunctional Axes3D.set_frame_on and get_frame_on methods.#25648timhoffm merged 4 commits intomatplotlib:mainfrom
Conversation
timhoffm
left a comment
There was a problem hiding this comment.
I think we need to keep these functions and raise NotImplementedError, because by removing we would inherit the functionality from Axes, which does not work for 3D.
Ok. The python docs state that |
|
From the note in the docs, it looks like the recommended approach is to set the method to |
|
Setting to none (plus leaving a comment there) seems the right approach. Thanks for checking the meaning of NotImplementedError. |
|
My understanding of the guidance is to set the actual method to |
|
Sorry for not seeing this until now. Good that things were clarified in the meanwhile. I think a note in doc/api/next_api_changes/removals/ would be nice. Basically saying that they were not working and therefore removed. If nothing else we can point at it, in case someone reports an error later. Other than that, is should be good to go! |
PR Summary
Fixes #24689. Remove
Axes3D.set_frame_onandget_frame_onfrom the codebase and from the link in the documentation.