MNT: deprecate unused numdecs LogLocator param #25651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
535f7f4 to
5609f83
Compare
|
It seems like this has not been used for quite some time. However, I guess an option is to make it None per default and then use it rather than the computed |
|
It was actually only removed in #24439. I could not find any other usage of it. |
|
I think we should also deprecate the public attribute. Probably means we have to run though through properties for a cycle as well. |
bfb28ab to
d296203
Compare
timhoffm
approved these changes
Apr 12, 2023
d296203 to
fe0b069
Compare
QuLogic
reviewed
Apr 12, 2023
Co-authored-by: Elliott Sales de Andrade <[email protected]>
oscargus
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
As far as I can tell, this parameter is not used for anything.
Closes #25638
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst