-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
DOC: update/fix autoscaling documentation #25656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers
or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
Co-authored-by: Elliott Sales de Andrade <[email protected]>
Please wrap the lines to ensure linting passes. |
Hello, @alissaahodge - the CircleCI failures here are unrelated (see #25672). Welcome! |
Thanks! cause I'm not really sure why there's been test failures on this PR when it codedev says "No Files covered by tests were changed" in this PR |
Re-opening to restart CI. |
I just realized we have some other issue with CircleCI; @alissaahodge can you rebase this PR so that it will work again? |
@QuLogic okay, I just synced my forked repo with matplotlib:main |
We do generally prefer rebasing over merging, but as there are also a few extra commits here, I will just squash while merging to avoid re-running all CI again. |
Thanks @alissaahodge! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
This PR resolves #25613 by fixing the documentation in the margin section of the autoscaling documentation page so that it is easier to follow and understand.
Before being opened as an issue, this comment was initially under another issue of the same topic. This can be found here: #25599 (comment)
PR Checklist
Documentation and Tests
pytest
passes)Release Notes
.. versionadded::
directive in the docstring and documented indoc/users/next_whats_new/
.. versionchanged::
directive in the docstring and documented indoc/api/next_api_changes/
next_whats_new/README.rst or next_api_changes/README.rst