Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC: update/fix autoscaling documentation #25656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 13, 2023
Merged

Conversation

alissaahodge
Copy link
Contributor

@alissaahodge alissaahodge commented Apr 10, 2023

This PR resolves #25613 by fixing the documentation in the margin section of the autoscaling documentation page so that it is easier to follow and understand.

Before being opened as an issue, this comment was initially under another issue of the same topic. This can be found here: #25599 (comment)

PR Checklist

Documentation and Tests

  • [N/A ] Has pytest style unit tests (and pytest passes)
  • [N/A ] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [ N/A] New plotting related features are documented with examples.

Release Notes

  • [N/A ] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [N/A ] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • [N/A ] Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@alissaahodge alissaahodge changed the title Update/Fix autoscaling documentation DOC: update/Fix autoscaling documentation Apr 10, 2023
@alissaahodge alissaahodge changed the title DOC: update/Fix autoscaling documentation DOC: update/fix autoscaling documentation Apr 10, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@QuLogic
Copy link
Member

QuLogic commented Apr 12, 2023

Please wrap the lines to ensure linting passes.

@melissawm
Copy link
Member

Hello, @alissaahodge - the CircleCI failures here are unrelated (see #25672). Welcome!

@alissaahodge
Copy link
Contributor Author

Thanks! cause I'm not really sure why there's been test failures on this PR when it codedev says "No Files covered by tests were changed" in this PR

@QuLogic QuLogic closed this Apr 13, 2023
@QuLogic
Copy link
Member

QuLogic commented Apr 13, 2023

Re-opening to restart CI.

@QuLogic QuLogic reopened this Apr 13, 2023
@QuLogic
Copy link
Member

QuLogic commented Apr 13, 2023

I just realized we have some other issue with CircleCI; @alissaahodge can you rebase this PR so that it will work again?

@alissaahodge
Copy link
Contributor Author

@QuLogic okay, I just synced my forked repo with matplotlib:main

@QuLogic
Copy link
Member

QuLogic commented Apr 13, 2023

We do generally prefer rebasing over merging, but as there are also a few extra commits here, I will just squash while merging to avoid re-running all CI again.

@QuLogic QuLogic merged commit b86ebba into matplotlib:main Apr 13, 2023
@QuLogic
Copy link
Member

QuLogic commented Apr 13, 2023

Thanks @alissaahodge! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

@oscargus oscargus added this to the v3.8.0 milestone Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[Doc]: better document default margins
4 participants