Added autoscaling support for add_collection3d #25659
Conversation
Fixes #17130 The code does work but might not be the cleanest implementation. However because a lot of the required functionality which would normally do this is grandfathered in from 2D matplotlib, a clean solution would require extensive writing/rewriting of the 3D side of things. Also I was only able to implement this for Line3DCollection, and PolyCollection, despite add_collection3d also supporting LineCollections, and PatchCollections. Sadly I could not figure out implementation of the same 3D to 2D workarounds for those datatypes.
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
Something seems to have happened that every line has been changed, making it very hard to see what the actual change is here. One likely explanation would be that line endings were converted to windows line endings. You can set up The files as they are checked in to git should have Please also make sure to squash/rebase to preserve the https://matplotlib.org/stable/devel/development_workflow.html#rewriting-commit-history |
PR Summary
Fixes #17130
The code does work but might not be the cleanest implementation. However because a lot of the required functionality which would normally do this is grandfathered in from 2D matplotlib, a clean solution would require extensive writing/rewriting of the 3D side of things.
Also I was only able to implement this for Line3DCollection, and PolyCollection, despite add_collection3d also supporting LineCollections, and PatchCollections. Sadly I could not figure out implementation of the same 3D to 2D workarounds for those datatypes.
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst