Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adding getters/setters for Text and Annotation class #25755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Adding getters/setters for Text and Annotation class #25755

wants to merge 2 commits into from

Conversation

NikosNikolaidis02
Copy link

Pull request for the issue #25675

I've added getters/setters for Text and Annotation class on text.py

Getters/setters of antialiased for class Text
Getters/setters of antialiased for class Annotation
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@ksunden
Copy link
Member

ksunden commented Apr 24, 2023

Something seems to have happened that caused every line of that file to differ. Most likely this is due to Windows line endings being checked into git. You probably want to do git config --global core.autocrlf true

Reference: https://docs.github.com/en/get-started/getting-started-with-git/configuring-git-to-handle-line-endings

(And then squash the commit down to keep the diff only what you actually want)

This makes this PR essentially impossible to review (as well as already causing a conflict).

@melissawm
Copy link
Member

Hello @NikosNikolaidis02 - are you planning on addressing the comment above? You probably want to revert these changes and then only touch the lines you are actively modifying so that the PR is reviewable. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants