Set PostScript language level to 3 #25769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently use various operators from level 2: - `<<` - `>>` - `colorimage` - `glyphshow` - `makepattern` - `rectfill` - `selectfont` - `setpagedevice` - `setpattern` and from level 3: - `ShadingType` - `shfill` - Type 42 fonts, possibly without any conditions or fallback, so we should be explicit about what we require. This is already part of the xpdf distiller at level 2, but not ghostscript. Since the distiller is optional though, we shouldn't rely on that.
This is just a bunch of shortcut procedure definitions for Matplotlib's internal use; there's not much use for them externally.
Since we require language level 2 now, we can use this directly.
I only change places that used the exact same formatting, and not cases of, e.g., `%f` or `%g`.
ksunden
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
We currently use various operators from level 2:
<<>>colorimageglyphshowmakepatternrectfillselectfontsetpagedevicesetpatternand from level 3:
ShadingTypeshfillwithout any conditions or fallback, so we should be explicit about what we require. This is already part of the xpdf distiller at level 2, but not ghostscript. Since the distiller is optional though, we shouldn't rely on that.
Also, since we would now require at least level 2, we can use the
rectclipoperator.PR Checklist
Linked Issue
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst