Small axislines.Axes cleanups. #25774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksunden
reviewed
Apr 26, 2023
| @@ -0,0 +1,4 @@ | |||
| Callable axisartist Axes | |||
| ~~~~~~~~~~~~~~~~~~~~~~~~ | |||
| Calling an axisartit Axes to mean `.Axes.axis` is deprecated; explicitly call | |||
There was a problem hiding this comment.
Suggested change
| Calling an axisartit Axes to mean `.Axes.axis` is deprecated; explicitly call | |
| Calling an axisartist Axes to mean `.Axes.axis` is deprecated; explicitly call |
timhoffm
approved these changes
Apr 26, 2023
- Deprecate the "callable axes" API, which is not present anywhere else nor documented nor tested. - No need to set the transform on the GridlinesCollection; _set_artist_props takes care of that.
oscargus
approved these changes
Apr 27, 2023
7 tasks
ksunden
added a commit
to ksunden/matplotlib
that referenced
this pull request
Apr 27, 2023
eslothower
pushed a commit
to eslothower/matplotlib
that referenced
this pull request
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist
Linked Issue
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst