Fix broken symlinks for expected images on WSL #25792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for WSL2 and WSL1 Cleanup
2 tasks
|
Thanks for this! Is there any documentation on the reported uname in WSL? |
|
Good question! The best I can find is microsoft/WSL#4555, so I added a check for WSL1 as well. |
QuLogic
reviewed
May 2, 2023
oscargus
reviewed
May 2, 2023
ceed678 to
aa0cda7
Compare
|
Thanks all, cleaned that up a bit. FYI, on Windows 10, platform.uname().release returns |
ksunden
reviewed
May 2, 2023
ksunden
approved these changes
May 15, 2023
QuLogic
approved these changes
May 16, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 16, 2023
QuLogic
added a commit
that referenced
this pull request
May 16, 2023
…792-on-v3.7.x Backport PR #25792 on branch v3.7.x (Fix broken symlinks for expected images on WSL)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
On WSL for image comparison tests, when placing the expected image in the results_images folder, symlinks are broken when accessing those images afterwards via the Windows interface. The symlink command does not fail, so the error logic does not catch it and we need to add a check for this special case.
Before, when opening an *-expected.png file:
After, the image opens correctly.
PR checklist