-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fix incorrect usage of nargs_error. #25863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nargs_error simply returns the exception, the caller needs to throw it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess these are not tested then?
No tests, but I'll leave adding tests as an exercise to the reader. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
This bug is not on the 3.7.x branch, merge failures look like
|
Yep, this was my fault in #25609, and it was not backported. |
nargs_error simply returns the exception, the caller needs to throw it.
PR summary
PR checklist