-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
DOC: clarify how colorbar steals space #25873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
timhoffm
merged 3 commits into
matplotlib:main
from
tacaswell:doc/colorbar_spacestealing
May 15, 2023
Merged
DOC: clarify how colorbar steals space #25873
timhoffm
merged 3 commits into
matplotlib:main
from
tacaswell:doc/colorbar_spacestealing
May 15, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Wrzlprmft Does this make the expected behavior clearer? |
story645
reviewed
May 12, 2023
jklymak
reviewed
May 13, 2023
timhoffm
reviewed
May 13, 2023
Yes, but as discussed on the original issue, I think that the object structure is the problem, not the documentation. |
Co-authored-by: Tim Hoffmann <[email protected]> Co-authored-by: Jody Klymak <[email protected]>
2ee6498
to
92d82a9
Compare
timhoffm
reviewed
May 14, 2023
Co-authored-by: Tim Hoffmann <[email protected]>
timhoffm
approved these changes
May 15, 2023
|
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Jun 29, 2023
…stealing DOC: clarify how colorbar steals space (cherry picked from commit dbe7c2d)
This was referenced Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
In looking at #25871 I noted that the documentation on colorbar was not clear about the default behavior.
The docstring from
ax
explains the default behavior of thecax
parameter and nothing explained the default value ofax
.