Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Doc]: Fix navigation sidebar for Animation examples #25977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2023

Conversation

Mubin17
Copy link
Contributor

@Mubin17 Mubin17 commented May 25, 2023

PR summary

This pull request is to address Issue #25836

PR checklist

@Mubin17
Copy link
Contributor Author

Mubin17 commented May 25, 2023

@QuLogic @rcomer @codingtosh automatic check of the doc build and a link that allows us to view how the docs look is working now. Based on a quick check the side navigation seems to be working fine as well.

Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks again @Mubin17 !

@codingtosh
Copy link

@Mubin17 LGTM, desired outcome is achieved. 🎉

Just a nit for next time, it will help with maintenance if you provide more context in your commit messages. Finding out which files were changed can be known by using git log --stat / git log --name-only if someone was going through the logs or by git diff / git show if someone wanted to reference your commit in particular, commit message should focus on the changes introduced and why, what they fix, any future scope etc.

@melissawm Thanks for the code suggestions 👍

@QuLogic QuLogic added this to the v3.7-doc milestone May 25, 2023
@QuLogic QuLogic changed the title [Doc][Examples Gallery]: Side Navigation Section breaks on Animation [Doc]: Fix navigation sidebar for Animation API page May 25, 2023
@QuLogic QuLogic changed the title [Doc]: Fix navigation sidebar for Animation API page [Doc]: Fix navigation sidebar for Animation examples May 25, 2023
@QuLogic QuLogic merged commit 28a0205 into matplotlib:main May 25, 2023
@QuLogic
Copy link
Member

QuLogic commented May 25, 2023

I squash merged to fix the commit message.

@QuLogic
Copy link
Member

QuLogic commented May 25, 2023

Thanks @Mubin17! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

QuLogic added a commit that referenced this pull request May 25, 2023
…977-on-v3.7.1-doc

Backport PR #25977 on branch v3.7.1-doc ([Doc]: Fix navigation sidebar for Animation examples)
rcomer added a commit that referenced this pull request May 25, 2023
…977-on-v3.7.x

Backport PR #25977 on branch v3.7.x ([Doc]: Fix navigation sidebar for Animation examples)
@Mubin17 Mubin17 deleted the Mubin17/Issue#25836 branch May 26, 2023 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants