CI: Use scientific-python/upload-nightly-action #26023
Conversation
* Use the scientific-python/upload-nightly-action GitHub Action to upload the nightly wheels to the scientific-python-nightly-wheels Anaconda Cloud package index (https://anaconda.org/scientific-python-nightly-wheels). For security best practices pin at the commit sha corresponding to the last stable release and let Dependabot update the commit sha and comment as new releases come out. - c.f. https://github.com/scientific-python/upload-nightly-action
* Remove the workflow step for querying and removing all but the last 5 nightly wheel uploads to the scientific-python-nightly-wheels Anaconda Cloud package index as this is now centrally done by the Scientific Python org for all projects that upload to https://anaconda.org/scientific-python-nightly-wheels. - c.f. scientific-python/upload-nightly-action#12
|
As far as the removals go, upstream does not yet actually implement deleting, but I'm fine with saying "oh, they will, and if it becomes an actual problem before they do, easy enough to put back, so cross that bridge when we come to it" |
Yeah, and as scientific-python/upload-nightly-action#12 will probably be merged in the next 24 hours I don't see any harm in there potentially being 6 wheels up on the package index for a few hours in the worst case scenario. As soon as it is merged I'm also going to trigger a manual run of the wheel removal workflow with workflow dispatch. |
@ksunden has you covered and did this a few days ago. :) https://anaconda.org/scientific-python-nightly-wheels/matplotlib/files
$ docker run --rm -ti python:3.11 /bin/bash
root@e22e7dd70b46:/# python -m pip download --index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple --no-deps matplotlib
Looking in indexes: https://pypi.anaconda.org/scientific-python-nightly-wheels/simple
Collecting matplotlib
Downloading https://pypi.anaconda.org/scientific-python-nightly-wheels/simple/matplotlib/3.8.0.dev1157%2Bg2f778fda79/matplotlib-3.8.0.dev1157%2Bg2f778fda79-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (11.6 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 11.6/11.6 MB 11.3 MB/s eta 0:00:00
Saved /matplotlib-3.8.0.dev1157+g2f778fda79-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
Successfully downloaded matplotlib
WARNING: There was an error checking the latest version of pip.
root@e22e7dd70b46:/# ls matplotlib-3.8.0.dev1157+g2f778fda79-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
matplotlib-3.8.0.dev1157+g2f778fda79-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
root@e22e7dd70b46:/# edit: Er, sorry maybe you meant automatically uploaded using the changes in PR #25950? |
|
That was manual though, and won't confirm the workflow is working. |
Gotcha. 👍 Okay that will happen later tonight then now that PR #25950 is in. After that happens, if you'd like to see an additional example of the workflow
|
|
Oh but you want to check that the |
|
And with https://github.com/matplotlib/matplotlib/actions/runs/5151045894/jobs/9275848789 that's up and deploying correctly $ docker run --rm -ti python:3.11 /bin/bash
root@b6fb237233dd:/# python -m pip download --index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple --no-deps matplotlib
Looking in indexes: https://pypi.anaconda.org/scientific-python-nightly-wheels/simple
Collecting matplotlib
Downloading https://pypi.anaconda.org/scientific-python-nightly-wheels/simple/matplotlib/3.8.0.dev1192%2Bgbb335a115c/matplotlib-3.8.0.dev1192%2Bgbb335a115c-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (11.6 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 11.6/11.6 MB 6.9 MB/s eta 0:00:00
Saved /matplotlib-3.8.0.dev1192+gbb335a115c-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
Successfully downloaded matplotlib
WARNING: There was an error checking the latest version of pip.
root@b6fb237233dd:/# 👍 |
scientific-python/upload-nightly-action#12 is now merged and has been run successfully (c.f. scientific-python/upload-nightly-action#12 (comment)). |
PR summary
Follow up PR to PR #25950.
Use the
scientific-python/upload-nightly-actionGitHub Action to upload the nightly wheels to thescientific-python-nightly-wheelsAnaconda Cloud package index. For security best practices pin at the commit sha corresponding to the last stable release and let Dependabot update the commit sha and comment as new releases come out.Remove the workflow step for querying and removing all but the last 5 nightly wheel uploads to the scientific-python-nightly-wheels Anaconda Cloud package index as this is now centrally done by the Scientific Python org for all projects that upload to https://anaconda.org/scientific-python-nightly-wheels.
PR checklist