Better document the semantics of get_text_width_height_descent. #26028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including whitespace seems to be the current behavior for agg and makes right-alignment works as it does. It is also necessary to make e.g. the currently PR'ed rainbow_text (based on `annotation(..., xycoords=textobj)` implementation work. Documenting the behavior is in particular useful for third-party backend implementers (mplcairo got this wrong previously).
timhoffm
approved these changes
Jun 1, 2023
|
Anybody can merge after CI pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including whitespace seems to be the current behavior for agg and makes right-alignment works as it does. It is also necessary to make e.g. the currently PR'ed rainbow_text (based on
annotation(..., xycoords=textobj)implementation work.Documenting the behavior is in particular useful for third-party backend implementers (mplcairo got this wrong previously).
PR summary
PR checklist