Factor out common checks for set_data in various Image subclasses. #26070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Jun 4, 2023
lib/matplotlib/image.py
Outdated
Comment on lines
692
to
693
| def _prepare_array(A): | ||
| # Common checks and typecasts on A for various Image subclasses. |
There was a problem hiding this comment.
"prepare_array" is a bit vague.
Suggested change
| def _prepare_array(A): | |
| # Common checks and typecasts on A for various Image subclasses. | |
| def _normalize_image_array(A): | |
| """ | |
| Transform image-like input into a normalized array represenation, | |
| that is used as data format in Image subclasses. | |
| """ |
There was a problem hiding this comment.
Did you intentionally not take the docstring?
There was a problem hiding this comment.
oops, missed it. reworded and included now.
timhoffm
approved these changes
Jun 5, 2023
ksunden
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
PR checklist