-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
added note about python 3 to venv #26084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Do we want to cross-reference https://peps.python.org/pep-0394 ? Mac may be the most common hold out here, but what |
On my pop os (ubuntu derivative) system, Perhaps we should just change the example to use |
Pep-394 states
So I would not universally go for |
Have wheels progressed to the level where we want our beginner install docs to talk about venv first rather than conda? I think anyone who uses the system version of Python on a Mac is probably going to be sad sooner rather than later. |
The continuation of that sentence, though, is:
Since the particular case in this example is "how do I set up a venv from system python", that implies that this is the particular case where that can't be relied on... |
To be clear, I am perfectly fine to leave it as |
I accepted the commit but I'm hesitant on linking out to the pep cause it might overwhelm the target audience. |
You could prepare that with context:
and/or: put this sentence in a footnote? That would make it less prominent. |
c823a1d
to
b8d3a84
Compare
doc/devel/development_setup.rst
Outdated
@@ -127,6 +127,9 @@ The simplest way to do this is to use either Python's virtual environment | |||
<file folder location>\Scripts\activate.bat # Windows cmd.exe | |||
<file folder location>\Scripts\Activate.ps1 # Windows PowerShell | |||
|
|||
On some systems, you may need to type ``python3`` instead of ``python``. | |||
For the technical reasons for this note, please see `PEP-394 <https://peps.python.org/pep-0394>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the technical reasons for this note, please see `PEP-394 <https://peps.python.org/pep-0394>`_. | |
For the technical reasons, please see `PEP-394 <https://peps.python.org/pep-0394>`_. |
Can be left out because it does not add information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The clause felt a little ambiguous without it.
Co-authored-by: esibinga <[email protected]> Co-authored-by: Tim Hoffmann <[email protected]>
…084-on-v3.7.x Backport PR #26084 on branch v3.7.x (added note about python 3 to venv)
…084-on-v3.7.1-doc Backport PR #26084 on branch v3.7.1-doc (added note about python 3 to venv)
PR summary
Apparently on mac, python may not be added to path but python 3 is, so small note to flag that. (also demoing draft pr)