Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MNT] Update nightly wheels install location #26111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

ksunden
Copy link
Member

@ksunden ksunden commented Jun 12, 2023

PR summary

I had originally thought this was included in #25950 (hence why I had waited so long to merge it...), but apparently it was not.

Now that both pandas and numpy are uploading to the new location, this is the expected install location for new nightlies

PR checklist

I had originally thought this was included in matplotlib#25950 (hence why I had waited so long to merge it...), but apparently it was not.

Now that both pandas and numpy are uploading to the new location, this is the expected install location for new nightlies
@tacaswell tacaswell added this to the v3.7-doc milestone Jun 12, 2023
@tacaswell tacaswell merged commit 2811576 into matplotlib:main Jun 12, 2023
@lumberbot-app
Copy link

lumberbot-app bot commented Jun 12, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.7.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 2811576c65d7d6bd5ef6d02025c60b3dac302774
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #26111: [MNT] Update nightly wheels install location'
  1. Push to a named branch:
git push YOURFORK v3.7.x:auto-backport-of-pr-26111-on-v3.7.x
  1. Create a PR against branch v3.7.x, I would have named this PR:

"Backport PR #26111 on branch v3.7.x ([MNT] Update nightly wheels install location)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@lumberbot-app
Copy link

lumberbot-app bot commented Jun 12, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.7.1-doc
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 2811576c65d7d6bd5ef6d02025c60b3dac302774
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #26111: [MNT] Update nightly wheels install location'
  1. Push to a named branch:
git push YOURFORK v3.7.1-doc:auto-backport-of-pr-26111-on-v3.7.1-doc
  1. Create a PR against branch v3.7.1-doc, I would have named this PR:

"Backport PR #26111 on branch v3.7.1-doc ([MNT] Update nightly wheels install location)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@tacaswell tacaswell modified the milestones: v3.7-doc, v3.7.2 Jun 12, 2023
@ksunden
Copy link
Member Author

ksunden commented Jun 12, 2023

since this only affects scheduled CI runs, that point to the default branch only, I don't think this needs to be backported.

@ksunden ksunden modified the milestones: v3.7.2, v3.8.0 Jun 12, 2023
@ksunden ksunden deleted the nightlies_install_loc branch June 12, 2023 16:28
@tacaswell
Copy link
Member

ah, sorry I was confused.

@tacaswell
Copy link
Member

Did we update the docs on how users should install the nightlies?

@ksunden
Copy link
Member Author

ksunden commented Jun 12, 2023

That was done in #26006, thought that was not (yet) backported... it is on devdocs, but not on stable/3.7 yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants