Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Enable branch coverage for C/C++ code #26130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2023
Merged

Conversation

oscargus
Copy link
Member

@oscargus oscargus commented Jun 15, 2023

PR summary

As mentioned here: #17497 (comment)

PR checklist

@oscargus oscargus marked this pull request as ready for review June 15, 2023 12:58
@QuLogic
Copy link
Member

QuLogic commented Jun 15, 2023

This seems reasonable, and though the status doesn't mention it, it seems like there's a lot of coverage reduction in the result. I guess that's expected since we didn't really test a lot of the error branches?

@oscargus
Copy link
Member Author

The reduction is expected as earlier an if-clause was considered covered even if only one of the paths was covered. Now it is only partially covered (not sure how that counts as percentage though). With that said, I do not really understand how some things that are not conditional are considered "partially" covered now.

@ksunden ksunden added this to the v3.8.0 milestone Aug 5, 2023
@ksunden ksunden merged commit 868004b into matplotlib:main Aug 5, 2023
@oscargus oscargus deleted the lcovbranch branch August 5, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants