-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Adding a dynamically resize of mathtext symbol table #26183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a dynamically resize of mathtext symbol table #26183
Conversation
Thank you! However, I do not think that having complete columns is really the main optimization objective that we want. Basically, the main problem is the length of some of the LaTeX commands. So if anything, I'd try to come up with some good heuristic to determine a suitable number of columns based on that. (However, it should be noted that it is almost impossible to come up with a perfect one as the columns will not have the same width anyway, so if all other columns only contains "short" commands there can be more columns compared to if all contains "long" commands.) Also, it seems like you have some unrelated changes in |
Yes, i don't want this change to happen it's from another change |
We can also optimize this by find the perfect combination for the lenght of the string |
@oscargus Can you check it? |
As I said, I do not believe in this approach, but I'd let e.g. @story645 chip in if it is an OK solution for the issue. Also, it seems like there has been something happening to your branch which must be fixed. Not really clear what and how though... Probably a case of either starting a new branch and copy-and-paste the relevant parts or use |
#26191 I've created a new branch to resolve the previous problems on this PR |
PR summary
I tried to find a more dynamic way to calculate the number of columns in order to have rows as more completed as possible. I've added the function
columns_calculation
which illustrates the function I described.PR checklist