setupext: put pkg-config -I, -L, -l locations at the head of the list #2623
Conversation
The assumption here is that we want the pkg-config info to take precedence, so its -I and -L output should be prepended, not appended to the lists used to construct the compiler and linker commands. It is less clear whether the -l info also should be prepended, as it is in the changeset; ideally, it wouldn't matter, but for some compilers, it might. If so, -l can be handled separately from -I and -L.
|
Let's make it all prepended, I think, for now, as you've done. Note to self: This should be cherry-picked to the 1.3.x branch. |
setupext: put pkg-config -I, -L, -l locations at the head of the list
setupext: put pkg-config -I, -L, -l locations at the head of the list
|
Cherry-picked as 4af8015 |
|
Is this going to get into 1.3.2? Because right now, doing a standard |
|
Yes, this will be in 1.3.2, if one is made. |
|
Hm, this sounds rather vague given that this is a pretty nasty show-stopper. After all, people won't be able to pull in matplotlib if they're using pip. Given that there were about 2 months between 1.3.0 and 1.3.1, and it's now been almost 4 months since 1.3.1, what are the chances that 1.3.2 will be releases very soon? |
|
+1 it'd be super awesome if we could get a 1.3.2 with this fix |
|
@benesch Why would you prefer a 1.3.2 over using a 1.4.0? |
|
Oh, I'm all for a 1.4.0! I just took a quick glance at the milestones and 1.3.2 seemed more feasible than a 1.4.0, but I'm not familiar with the matplotlib development cycle. (It just really sucks that Anyway, thanks for all your hard work! |
|
sudo apt-get install libfreetype6-dev DONE |
This addresses #2622.
The assumption here is that we want the pkg-config info to take
precedence, so its -I and -L output should be prepended, not
appended to the lists used to construct the compiler and linker
commands. It is less clear whether the -l info also should
be prepended, as it is in the changeset; ideally, it wouldn't
matter, but for some compilers, it might. If so, -l can
be handled separately from -I and -L.