DOC: Fix image_rotator #26269
Merged
DOC: Fix image_rotator #26269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by replacing step with stairs (follow-up to matplotlib#26233) and replacing the second step entry with the fill_between basic plot
|
I'm not sure there's value add to having this be a curated list rather than just auto pulling/generating the list from whichever files are sitting in plot_type gallery? |
tacaswell
approved these changes
Jul 6, 2023
|
@story645 this was solely done this way to actually get it done. |
|
@jklymak that's fair, but would you be opposed to automating it? |
|
No, I wouldn't be opposed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Fix
image_rotatorby replacing removed step with stairs (follow-up to #26233) and replacing the second step entry with fill_between basic plot (this choice is of course arbitrary to a certain degree).Currently the devdocs show a missing image:
PR checklist