Deprecate wrappers combining axes_grid1 and axisartist. #26330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4c6eb0 to
5b8a062
Compare
They combine two relatively obscure features, are untested, and are readily provided by the axes_class API (nowadays we'd probably not provide such wrappers anyways).
story645
approved these changes
Jul 18, 2023
QuLogic
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They combine two relatively obscure features, are untested, and are readily provided by the axes_class API (nowadays we'd probably not provide such wrappers anyways).
Not a huge argument but the duplicated classes also make sphinx references somewhat tedious (one must provide nearly the entire module path to disambiguate the references).
PR summary
PR checklist