Boxplot: Median line too long after changing linewidth #26345
Conversation
test
Update test_axes.py
Boxplot: Median line too long after changing linewidth--Not Yet
|
Consider adding a before and after plot to the PR description so we know what changed. I'm also confused how this can be tested with a figures_equal rather than a proper image test - but I may not understand what you have done properly. |
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
Hi @YueHuaJi - did you really mean to close this? |
PR Description
When changing the .linewidth property of the median line in boxplots, the line will extend beyond the box width.
PR Changes
After we refer to many methods, we chose one method as the main implementation method, which is as followed:
First，we added a default capstyle preventing this from happening.
Second， we also changed the zdelta, so that the median and mean lines no longer overlap the box's border.
PR checklist