Fix bad histogramming bins in mri/eeg example. #26352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version of the histogram showed regular "spikes" which are entirely artefactual; they come from the fact that we were binning (effectively) integer data with floating point bins that did not all cover the same number of ints (even though they have the same floating point width). Using an explicit, integer binsize avoids this issue.
timhoffm
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of the histogram showed regular "spikes" which are entirely artefactual; they come from the fact that we were binning (effectively) integer data with floating point bins that did not all cover the same number of ints (even though they have the same floating point width). Using an explicit, integer binsize avoids this issue.
old
new
(I also no longer normalize the histogram to 0-1 as I don't think this adds much, but I can restore that too if it is strongly preferred.)
PR summary
PR checklist