Fix removal of Figure-level artists #26365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyCharm has been warning that `Artist.figure` should be a `Figure|None`, not a `bool` as is set in this block. Based on the previous section of code, I think setting the figure to stale (if the Axes was not already set stale, meaning the Artist was on a Figure *only*) was the intended behaviour.
|
My recollection is that it was trying to make sure that you could not do fig1, ax = plt.subplots()
fig2 = plt.figure()
ax.remove()
fig2.add_axes(ax) |
|
But this isn't done for Axes-level artists? |
|
I thought at was! import matplotlib as plt
fig, (ax1, ax2) = plt.subplots(2)
ln, = ax1.plot([0, 1, 2])
ln.remove()
ax2.add_artist(ln)
%history
ln.axes
ln.axes is ax2
ln.set_clip_on(False)is super broken! The line is "in" |
|
I'm not sure why I came across it, but I see #25168 seems to be related to that, and there are two linked-but-unfinished PRs (one by you). |
tacaswell
approved these changes
Jul 21, 2023
|
Oh, that explains why I remember it having that behavior. As it stands, I think it is reasonable to take this PR as-is to not put spurious warnings in IDEs / mypy and defer making sure that re-adding Artists / Axes stays "broken" to a different PR. |
ksunden
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
PyCharm has been warning that
Artist.figureshould be aFigure|None, not aboolas is set in this block.Based on the previous section of code, I think setting the figure to stale (if the Axes was not already set stale, meaning the Artist was on a Figure only) was the intended behaviour.
This code is 8 years old, so I don't expect @tacaswell remembers the intention here, but the commit message does say "marks the parent axes/figure as stale", which I think indicates this PR is what's intended.
PR checklist