-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Improve some smaller typing issues #26407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has had types since 1.0.7, which is slightly newer than our requirement, but this change is only the test files anyway.
These can be set to `None` in their `__init__` or the property setter.
It's only there for `__init__` and immediately changed right after.
Mostly because these might be `TransformedBbox`.
These are semi-public.
The resample function from `_image` was missing, and bbox is allowed to be a function like `get_window_extent`.
Most calls use a single type.
Internally, a `PillowWriter` is sometimes used, and this should be supported from user code as well.
It is only ever created in `GridSpecBase.__getitem__` with `self` as argument, so must accept those instead of `GridSpec`.
We only ever pass a list internally.
Instead, fall back to the `object.__init_subclass__` definition.
This change is not strictly correct, as these style classes don't actually inherit from the surrounding class, but it allows one to pass an instance of the style classes directly.
ksunden
approved these changes
Aug 3, 2023
tacaswell
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Various and sundry things that I've come across trawling through
mypy --strict
. This is incomplete at the moment, and also based on #26403.PR checklist