Fix some bugs found by typing #26444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When iterables were added in matplotlib#6047, the test added a string. Typing correctly points out that that is not accepted, and in fact it does not do anything (as shown in the test image) because column keys are ints, not strings.
This is never called, is on an internal class, and the attribute it accesses doesn't exist as it was removed in matplotlib#22204.
The normal function returns a `str`, so this patch returning bytes is confusing.
tacaswell
approved these changes
Aug 3, 2023
ksunden
approved these changes
Aug 3, 2023
`LogFormatterSciNotation.sublabel` is not an attribute that exists. There is the private `LogFormatterSciNotation._sublabels`, but this obviously doesn't need to be set as the test is already passing.
|
Found one more thing: |
ksunden
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
There are 3 changes here:
Table.auto_set_column_widthin bug fix related #5479 #6047, the test added a string. Typing correctly points out that that is not accepted, and in fact it does not do anything (as shown in the test image) because column keys are ints, not strings, so the automatic width calculation is applied to nothing. So deprecate accepting random types here.Fonts.used_characterswas removed in Cleanup _mathtext internal API #22204, butFonts.get_used_characters(which just returns that attribute) was not. This is private and can be removed directly, AFAICT.find_tex_filemonkey patch in the test returned the wrong type, which doesn't technically break anything, but was confusing when comparing with the type stubs.PR checklist