-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
[DOC]: mathtext tutorial-consolidate explain and notes #26470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
story645
commented
Aug 8, 2023
•
edited
Loading
edited
- removed example section, expanded inline example, and added seealso out to example b/c I was confused on where to find the code and found clicking the image kinda unintuitive.
- rearranged top paragraphs to frontload mathtext and demphasize the implementation details
- changed the set of notes into a section and consolidated/clarified-see gitter convo - because felt like there were too many notes. I would prefer a table instead of a figure but couldn't get it working.
- moved things around a bit in the fonts section
- converted to sphinx-gallery mode
a1a1fd3
to
33e692d
Compare
QuLogic
reviewed
Aug 26, 2023
33e692d
to
29f5309
Compare
Moved things around so that I could start with a short what is mathtext that might be inaccurate - I'm not sure if mathtext is the parser/engine or the subset of TeX or both. Also thanks for the review! |
29f5309
to
08c0e77
Compare
timhoffm
reviewed
Aug 30, 2023
timhoffm
reviewed
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very nice guide now. 👍
Co-authored-by: Elliott Sales de Andrade <[email protected]> Co-authored-by: Tim Hoffmann <[email protected]>
340bf99
to
af6fbef
Compare
timhoffm
approved these changes
Aug 31, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 31, 2023
…plain and notes
oscargus
added a commit
that referenced
this pull request
Aug 31, 2023
…470-on-v3.8.x Backport PR #26470 on branch v3.8.x ([DOC]: mathtext tutorial-consolidate explain and notes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.