Disable add_html_cache_busting on Sphinx 7.1+
#26493
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
Thanks so much for fixing this and extra thanks for doing it so quickly! |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
|
Something went wrong ... Please have a look at my logs. It seems that the branch you are trying to backport to does not exist. |
|
@meeseeksdev backport to v3.8.x |
…493-on-v3.8.x Backport PR #26493 on branch v3.8.x (Disable ``add_html_cache_busting`` on Sphinx 7.1+)
…phinx 7.1+ (cherry picked from commit 48e2891)
PR summary
Hi,
In sphinx-doc/sphinx#11518, @story645 noted that MPL's documentation failed when running with Sphinx 7.1. This PR disables the custom
add_html_cache_busting()function withinconf.pywhen running on Sphinx 7.1 and later, in favour of Sphinx's new native asset checksum support.Thanks,
Adam
PR checklist