Fix input check in Poly3DCollection.__init__ #26532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksunden
approved these changes
Aug 15, 2023
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 16, 2023
oscargus
added a commit
that referenced
this pull request
Aug 16, 2023
…532-on-v3.8.x Backport PR #26532 on branch v3.8.x (Fix input check in Poly3DCollection.__init__)
QuLogic
pushed a commit
to QuLogic/matplotlib
that referenced
this pull request
Aug 18, 2023
…nit__ (cherry picked from commit 267b7c0)
oscargus
added a commit
that referenced
this pull request
Aug 18, 2023
…3.7.x Backport PR #26532: Fix input check in Poly3DCollection.__init__
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
PR checklist
So far higher level APIs like
plot_surfaceandplot_trisurfensure the input for callingPoly3DCollectionis valid so usually we won't trigger the bug.By inspecting test code coverage report, this part of code has never been tested. A test is added to ensure it works.
code for generating coverage report specifying folder - for people who may be curious