TYP: Add typing on mathtext internals #26541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pyparsing allows you to leave out the parameters (starting from the left) if they are unused.
mypy rightfully complains that these methods called in the base class don't exist, so correctly indicate what should be implemented there. The ABC is not strictly necessary, but it helps with understanding as a lot of these have code that makes them seem like _not_ an ABC.
Just as enabling the packrat cache occurs on the class overall, so does the reset.
oscargus
approved these changes
Aug 31, 2023
ksunden
approved these changes
Aug 31, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 31, 2023
QuLogic
added a commit
that referenced
this pull request
Aug 31, 2023
…541-on-v3.8.x Backport PR #26541 on branch v3.8.x (TYP: Add typing on mathtext internals)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This adds typing to all of
_mathtext.pyand cuts downmypy --stricterrors for it from >400 to 14 (all but one of which are pyparsing issues). As a proof of concept, this applies all type hints inline.There is also some refactoring to avoid re-using variables with mixed types, and adding more explicit types for some
SimpleNamespace. These could be split into separate PRs if desired, but are separate commits at least.It is based on #26540.
PR checklist