Use sys.platform over os.name #26576
Conversation
mypy does not recognize the latter [1], and there is a typing failure on Windows because of `os.geteuid`. [1] python/mypy#13002
|
Hmm, am I missing something, or did Cygwin not actually run? I definitely wanted to check that. |
|
Hmmm... the workflow looks like it should work and it appears to have worked recently on #26543 so not sure what is going on there... I'll close/open to cycle and see if it gets picked up... could be that the there is a narrow path where it doesn't quite get the right conditions... (which we should maybe try and figure out, but I'm at a bit of a loss) |
|
matplotlib/.github/workflows/cygwin.yml Lines 25 to 27 in a4dca24 I think it is failing to be triggered because no files in src (or the cygwin workflow file) were touched... We may wish to reconsider that restriction, at least for the "run because I labeled it" case, (though that may be hard to separate out) For now, I think you should be able to run it as a manually triggered run on your fork (I have the option on my fork, but can't trigger it on yours) |
|
OK, looks like it passed on my fork: https://github.com/QuLogic/matplotlib/actions/runs/5955561881/job/16154461275 |
…576-on-v3.8.x Backport PR #26576 on branch v3.8.x (Use sys.platform over os.name)
PR summary
mypy does not recognize the latter [1], and there is a typing failure on Windows because of
os.geteuid.[1] python/mypy#13002
PR checklist