Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FIX: array labelcolor for Tick #26598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2023
Merged

FIX: array labelcolor for Tick #26598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/matplotlib/axis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ def __init__(
if labelcolor is None:
labelcolor = mpl.rcParams[f"{name}.labelcolor"]

if labelcolor == 'inherit':
if cbook._str_equal(labelcolor, 'inherit'):
# inherit from tick color
labelcolor = mpl.rcParams[f"{name}.color"]

Expand Down
10 changes: 10 additions & 0 deletions lib/matplotlib/tests/test_axis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import numpy as np

import matplotlib.pyplot as plt
from matplotlib.axis import XTick


def test_tick_labelcolor_array():
# Smoke test that we can instantiate a Tick with labelcolor as array.
ax = plt.axes()
XTick(ax, 0, labelcolor=np.array([1, 0, 0, 1]))
Comment on lines +7 to +10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a test somewhere that this actually works?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m sorry I don’t understand the question.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, you've got this setup as a smoke test so I was wondering if somewhere in the code there's a test that passing an array to xtick color colors the tick the color of the array.

Copy link
Member

@timhoffm timhoffm Aug 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One can add that check via tick.label1.get_color() (and also for label2; and if you want to be even more precise check that tick1line, tick2line and gridline do not get that color).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I did intend to respond to this but have not been well for a few days. It looks like I’m too late now but there is this test that sets a labelcolor with a string and then checks it via the getter:

https://github.com/matplotlib/matplotlib/blob/main/lib/matplotlib/tests/test_axes.py#L6778-L6788

Is that enough or is there a concern that using an array could break things further along the process than the instantiation?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latter but also it's not a blocker and we can always add later if there's a bug that shows we should have added it ;)

Hope you're feeling better!