Clarify loading of backend FigureCanvas and show(). #26665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
reviewed
Aug 31, 2023
lib/matplotlib/pyplot.py
Outdated
| if not manager_pyplot_show: | ||
| raise ValueError( | ||
| "Backend `newbackend` defines neither `FigureCanvas.manager_class` nor " | ||
| "a toplevel `show` function") |
There was a problem hiding this comment.
Maybe I am missing something obvious (or do not see properly), but do we use backticks in error messages?
2dc4ae2 to
48e9e65
Compare
QuLogic
approved these changes
Sep 1, 2023
- FigureCanvas is now required to exist on backend modules (since the deprecation elapsed in 3.8) and we indeed already access that attribute directly when checking required_interactive_framework, so remove redundant getattrs. - Clarify the error message when manager_class is None *and* there's no global show(). (Previously an AttributeError would be raised.)
timhoffm
approved these changes
Sep 1, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 1, 2023
QuLogic
added a commit
that referenced
this pull request
Sep 1, 2023
…665-on-v3.8.x Backport PR #26665 on branch v3.8.x (Clarify loading of backend FigureCanvas and show().)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
PR checklist