Widgets: Remove deprecations and make arguments keyword only #26853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
08d9e2c to
989dda7
Compare
2e37748 to
e19633f
Compare
|
@oscargus do you mind holding off on any other deprecation removals? We would like to leave that as a good first issue for the sprint tomorrow. |
|
Sure, no problems! Didn't know that. |
14 tasks
|
No worries, we only decided yesterday. Also, this PR was very useful as an example of what to do. |
QuLogic
reviewed
Sep 22, 2023
e19633f to
705568a
Compare
QuLogic
approved these changes
Sep 22, 2023
Comment on lines
+1665
to
+1666
| if (i in inds["ind"] | ||
| or t.get_window_extent().contains(event.x, event.y)): |
There was a problem hiding this comment.
Fits in a line now:
Suggested change
| if (i in inds["ind"] | |
| or t.get_window_extent().contains(event.x, event.y)): | |
| if i in inds["ind"] or t.get_window_extent().contains(event.x, event.y): |
There was a problem hiding this comment.
I have a further PR that rewrites this loop, so let's just get this in for now.
anntzer
approved these changes
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
PR checklist