Removed the deprecated code from axis.py #26870
Conversation
|
Here is the release note from the deprecation |
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
| ``set_label1`` and ``set_label2`` | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
There was a problem hiding this comment.
Should be more specific about location:
| ``set_label1`` and ``set_label2`` | |
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |
| ``matplotlib.axis.Tick.set_label1`` and ``matplotlib.axis.Tick.set_label2`` | |
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
Hi @agautam478; 3.9 is branched now, so this can go in. Do you mind rebasing so that the CI results will be current? |
|
Thank you for your effort, however these changes got rolled into a larger deprecation commit in #28183, so closing now. |
PR summary
This PR removes the deprecated code during the version 3.8 from
lib/matplotlib/axis.pywhich is a sub issue in the parent issues here: #26865PR checklist