Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Deprecated code removed in animation.py #26872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2023
Merged

Deprecated code removed in animation.py #26872

merged 1 commit into from
Sep 23, 2023

Conversation

ananya314
Copy link
Contributor

@ananya314 ananya314 commented Sep 22, 2023 •
edited
Loading

PR summary

This PR removes 3.7-deprecated API from lib/matplotlib/animation.py which is mentioned in the issue here: #26865

PR checklist

@tacaswell tacaswell added this to the v3.9.0 milestone Sep 22, 2023
@ksunden
Copy link
Member

ksunden commented Sep 22, 2023

matplotlib/doc/api/prev_api_changes/api_changes_3.7.0/deprecations.rst

Line 107 in 04e1332

``Animation`` attributes

Here is the deprecation note that you can copy/edit for the removal note

github-actions[bot]
github-actions bot reviewed Sep 22, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

tacaswell
tacaswell reviewed Sep 22, 2023
View reviewed changes
doc/api/next_api_changes/removals/26865-AD.rst Outdated
@@ -0,0 +1,6 @@
``repeat``
~~~~~~~~~~~~~~~~~~~~~~~
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will need to be trimmed to the same length as the title (or the docs build will complain).

@tacaswell
Copy link
Member

Thank you!

Are you comfortable squashing this to one commit?

@ananya314 ananya314 force-pushed the ghc-matplotlib-deprecation branch from 6d984d4 to ae9e739 Compare September 22, 2023 20:38
@ananya314
Copy link
Contributor Author

Thank you! I've squashed to one commit

@ananya314 ananya314 force-pushed the ghc-matplotlib-deprecation branch from b7df38f to f49cf28 Compare September 22, 2023 21:27
@QuLogic QuLogic merged commit dd97219 into matplotlib:main Sep 23, 2023
@QuLogic
Copy link
Member

QuLogic commented Sep 23, 2023 •
edited
Loading

Thanks @ananya314! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

@ksunden ksunden mentioned this pull request Sep 25, 2023
Closed
14 tasks
@ananya314 ananya314 mentioned this pull request Sep 27, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@tacaswell tacaswell tacaswell approved these changes

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
Maintenance mentored: hackathon
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ananya314 @ksunden @tacaswell @QuLogic