Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Updated offsetbox.py #26880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Updated offsetbox.py #26880

wants to merge 1 commit into from

Conversation

Anjini2004
Copy link

PR summary

PR checklist

@ksunden
Copy link
Member

ksunden commented Sep 22, 2023

Thank you for your pull request!

Since these methods are fully deprecated, their implementation should also be removed.

Here are the deprecation notes that you can slightly reword to reflect removal rather than deprecation (they can both appear in the same file):

matplotlib/doc/api/prev_api_changes/api_changes_3.7.0/deprecations.rst

Line 191 in 04e1332

``OffsetBox.get_extent_offsets`` and ``OffsetBox.get_extent``

matplotlib/doc/api/prev_api_changes/api_changes_3.7.0/deprecations.rst

Line 211 in 04e1332

``offsetbox.bbox_artist``

github-actions[bot]
github-actions bot reviewed Sep 22, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

QuLogic
QuLogic reviewed Sep 22, 2023
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entirety of the functions marked with _api.deprecated should be removed.

@QuLogic QuLogic added this to the v3.9.0 milestone Sep 22, 2023
@tacaswell
Copy link
Member

xref #26865

tacaswell
tacaswell requested changes Sep 22, 2023
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove the deprecated method and add a API change note.

@ksunden
Copy link
Member

ksunden commented Sep 25, 2023

Thanks again for the pull request, however, looks like the required changes for this deprecation got merged in #26910, so unfortunately I am going to close this version. Thank you for your interest and we hope to hear from you again!

@ksunden ksunden closed this Sep 25, 2023
@ksunden ksunden mentioned this pull request Sep 25, 2023
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@tacaswell tacaswell tacaswell requested changes

Assignees
No one assigned
Labels
Maintenance mentored: hackathon
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Anjini2004 @ksunden @tacaswell @QuLogic