Add scatter test for datetime units #26882
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
I incorporated the issues you mentioned in my 2nd commit. |
|
|
| # rotate labels so they don't look clogged | ||
| for label in axs[0].get_xticklabels(): | ||
| label.set_rotation(40) | ||
| label.set_horizontalalignment('right') |
There was a problem hiding this comment.
With a shorter array, this might not be necessary; would have to see what it looks like then.
|
|
I needed to rotate axis labels because they were still clogged after I reduced array length
| np.random.seed(19680801) | ||
| y = np.cumsum(np.random.randn(N)) | ||
| fig, axs = plt.subplots(3, 1, layout='constrained', figsize=(6, 6)) | ||
| lims = [(np.datetime64('2005-02'), np.datetime64('2005-04')), |
There was a problem hiding this comment.
It doesn't look like lims is used
|
Thank you for the contribution! I noted one thing to clean up but it looks generally good to me. A note for whoever merges this, it closes the "Axes.scatter" item of #26864, not the whole ticket. |
eliminated unused variable according to feedback ('lims')
|
I deleted lims in my most recent pull request. Please review my request again. |
|
Thanks @seohyeon-lee-2025! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
PR summary
Closes issue #26864
added 3 subplots with datetime array on the x axis, y axis, and both axes.
PR checklist