Thanks to visit codestin.com
Credit goes to github.com

Skip to content

TST - Adding test_table() to test_datetimes.py #26898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

TST - Adding test_table() to test_datetimes.py #26898

wants to merge 5 commits into from

Conversation

iandw
Copy link

@iandw iandw commented Sep 23, 2023

PR summary

Adding a new test called "test_table" inside of the test_datetimes.py that tests that the axes.table function can generate a plot with datetime arrays.
Screenshot 2023-09-23 at 8 36 22 AM
Part of issue #26859 but does not close this issue fully.

PR checklist

@iandw iandw marked this pull request as ready for review September 23, 2023 14:25
@ksunden
Copy link
Member

ksunden commented Sep 25, 2023

Hmmm... This is one that it isn't actually exercising the units functionality, and is instead just being passed through str(x) as text cells...

I think this is correct behavior, and have no real dispersion to testing it, but it is an outlier compared to e.g. plot/scatter.

Thoughts @tacaswell?

@oscargus
Copy link
Member

Maybe one can simply use the difference between the column and row heading dates as cell values?

I somewhat agree with @ksunden but no harm to test this (although not obvious what could possibly break...).

@jklymak
Copy link
Member

jklymak commented Sep 28, 2023

@iandw thanks a lot for working on this, but I largely agree this isn't testing out handling of datetimes. I don't know what a reasonable test for datetimes would look like on a table as I don't think they map data to a coordinate.

@iandw
Copy link
Author

iandw commented Sep 28, 2023

I agree with all the feedback, I wasn't quite sure how to test this for date time either LOL, appreciate the honesty! Will close this for now, it was just a good experience to learn more about contributing to open source at GHC! Thanks all :)

@iandw iandw closed this Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants