Thanks to visit codestin.com
Credit goes to github.com

Skip to content

deprecated api tri #26909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 2, 2023
Merged

deprecated api tri #26909

merged 10 commits into from
Oct 2, 2023

Conversation

vigneshvetrivel8
Copy link
Contributor

@vigneshvetrivel8 vigneshvetrivel8 commented Sep 25, 2023 •
edited by ksunden
Loading

PR summary

Helps with #26865 (lib/matplotlib/tri/*.py).

PR checklist

github-actions[bot]
github-actions bot reviewed Sep 25, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@ksunden
Copy link
Member

ksunden commented Sep 25, 2023

The deprecation here is to remove the edited files entirely, as their contents/organization is now considered private (and thus they have _tri<x> python modules).

QuLogic
QuLogic requested changes Sep 25, 2023
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not removing the deprecations, but changing imports in files that are deprecated, which does not achieve the desired result. In fact, it causes more things to appear in the deprecated files.

@ksunden ksunden mentioned this pull request Sep 25, 2023
Closed
14 tasks
This was referenced Sep 26, 2023
Closed
Closed
ksunden
ksunden requested changes Sep 26, 2023
View reviewed changes
Copy link
Member

@ksunden ksunden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not edit the 00001-ABC.rst file, and instead make a new file e.g. 26909-VV.rst

You can copy the contents (and update to reflect removal instead of deprecation) from, which gives more context and says what to do instead:

matplotlib/doc/api/prev_api_changes/api_changes_3.7.0/deprecations.rst

Lines 81 to 86 in d60de5e

``matplotlib.tri`` submodules are deprecated
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The ``matplotlib.tri.*`` submodules are deprecated. All functionality is
available in ``matplotlib.tri`` directly and should be imported from there.

QuLogic
QuLogic reviewed Sep 27, 2023
View reviewed changes
@vigneshvetrivel8 vigneshvetrivel8 force-pushed the deprecated_api branch 2 times, most recently from ddc5bdb to d89567a Compare September 29, 2023 04:51
@QuLogic QuLogic mentioned this pull request Sep 29, 2023
Closed
5 tasks
@vigneshvetrivel8
Copy link
Contributor Author

Do i need to modify some more or is this enough. Is this PR ok.

QuLogic
QuLogic approved these changes Sep 30, 2023
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, except for the pre-commit linting issue. I'm going to have it fix it automatically for you.

@QuLogic
Copy link
Member

QuLogic commented Sep 30, 2023

pre-commit.ci autofix

@ksunden ksunden self-requested a review October 2, 2023 21:07
@ksunden ksunden added this to the v3.9.0 milestone Oct 2, 2023
@ksunden ksunden merged commit 5bf7e33 into matplotlib:main Oct 2, 2023
@QuLogic
Copy link
Member

QuLogic commented Oct 3, 2023

Thanks @vigneshvetrivel8! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

issamarabi pushed a commit to issamarabi/matplotlib that referenced this pull request Oct 5, 2023
@vigneshvetrivel8 @pre-commit-ci @issamarabi
deprecated api tri (matplotlib#26909)
eaab89f 
* deprecated api tri

* updated deprecated api tri

* updated deprecated api tri

* updated deprecated api tri

* updated deprecated api tri

* pre-commit.ci autofix

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@QuLogic QuLogic QuLogic approved these changes

@ksunden ksunden ksunden approved these changes

Assignees
No one assigned
Labels
Maintenance mentored: hackathon topic: tri
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vigneshvetrivel8 @ksunden @QuLogic