Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add test_contour under test_datetime.py#27013

Merged
QuLogic merged 6 commits intomatplotlib:mainfrom
kots14:axes-contour-unit-test-for-issue-26864
Dec 12, 2023
Merged

Add test_contour under test_datetime.py#27013
QuLogic merged 6 commits intomatplotlib:mainfrom
kots14:axes-contour-unit-test-for-issue-26864

Conversation

@kots14
Copy link
Contributor

@kots14 kots14 commented Oct 6, 2023 •
edited
Loading

PR summary

Attempting adding code for test_contour method in test_datetime.py mentioned in #26864

Image output -
test_datetime_contour

PR checklist

github-actions[bot]
github-actions bot reviewed Oct 6, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@kots14 kots14 changed the title Add test_contour #26864 Add test_contour under test_datetime.py Oct 6, 2023
kots14
kots14 commented Oct 6, 2023
View reviewed changes
@ksunden ksunden added this to the v3.9.0 milestone Oct 6, 2023
ksunden
ksunden approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@ksunden ksunden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having 6 instead of 3 plots is slightly unnecessary (Z does not actually go through units behavior, and both Z values are just floats anyway)

But it looks correct and is testing what we want to test here.

Thank you @kots14

@kots14
Copy link
Contributor Author

kots14 commented Oct 6, 2023

@ksunden Thank you for your feedback and for approving the changes.
In order to get this PR merged, is there any further modification expected?

@kots14 kots14 mentioned this pull request Oct 6, 2023
Open
64 tasks
QuLogic
QuLogic requested changes Dec 5, 2023
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose the extra 3 Axes could be removed if you're making updates.

@kots14
Copy link
Contributor Author

kots14 commented Dec 6, 2023

I suppose the extra 3 Axes could be removed if you're making updates.

You mean from these lines shall I remove 3?

ax1.contour(X_dates, Y_dates, Z_timestamps)
ax2.contour(X_dates, Y_ranges, Z_timestamps)
ax3.contour(X_ranges, Y_dates, Z_timestamps)
bx1.contour(X_dates, Y_dates, Z_ranges)
bx2.contour(X_dates, Y_ranges, Z_ranges)
bx3.contour(X_ranges, Y_dates, Z_ranges)

@ksunden
Copy link
Member

ksunden commented Dec 6, 2023

The last three (and get rid of the variables that become unused as a result).

@kots14 kots14 requested review from QuLogic and ksunden December 12, 2023 06:15
@QuLogic QuLogic merged commit 92cc8f5 into matplotlib:main Dec 12, 2023
@QuLogic
Copy link
Member

QuLogic commented Dec 12, 2023

Thanks @kots14! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

@kots14 kots14 deleted the axes-contour-unit-test-for-issue-26864 branch December 12, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@QuLogic QuLogic QuLogic approved these changes

@ksunden ksunden Awaiting requested review from ksunden

Assignees

No one assigned

Labels

topic: testing

Projects

First Time Contributors
Status: Merged

Milestone

v3.9.0

Development

Successfully merging this pull request may close these issues.

4 participants

@kots14 @ksunden @QuLogic @melissawm