-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add spines and ticks in rcParams #2702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -458,6 +458,9 @@ def linear_spine(cls, axes, spine_type, **kwargs): | |
else: | ||
raise ValueError('unable to make path for spine "%s"' % spine_type) | ||
result = cls(axes, spine_type, path, **kwargs) | ||
if not rcParams['axes.spines.{0}'.format(spine_type)]: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this should be a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That would also make it more clear what the default value was |
||
result.set_visible(False) | ||
|
||
return result | ||
|
||
@classmethod | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this doing anything? I can't see any diffs which are making use of it.