Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add test_plot_date in test_datetime.py #27037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kots14
Copy link
Contributor

@kots14 kots14 commented Oct 9, 2023

PR summary

Adding code for test_plot_date method in test_datetime.py mentioned in #26864

Image output -
test_plot_date_image

PR checklist

@melissawm
Copy link
Member

Hi @kots14, thanks for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

Copy link
Member

@ksunden ksunden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of an odd one in that despite sounding like it is doing things with dates, with these inputs actually just amounts to plot (and is a discouraged method because of that)... But it works and I guess no harm in testing it like this.

(For reference, it only does anything beyond plot if xdate=True or ydate=True are passed, at which point it sets the units of the axis)

@kots14
Copy link
Contributor Author

kots14 commented Oct 10, 2023

A bit of an odd one in that despite sounding like it is doing things with dates, with these inputs actually just amounts to plot (and is a discouraged method because of that)... But it works and I guess no harm in testing it like this.

(For reference, it only does anything beyond plot if xdate=True or ydate=True are passed, at which point it sets the units of the axis)

Should I include additional tests to accommodate this in the same test? Please suggest.

@ksunden
Copy link
Member

ksunden commented Oct 10, 2023

I'd say this is fine for this test file. If anything, I think I'd move towards actually deprecating this method, as it's been soft-deprecated (i.e. discouraged in the docstring, but not warning at runtime) since 3.5.

The date plotting parts of this method are already tested in test_axes.py (as full image comparison tests, so even more rigorous than we are wanting here initially).

@jklymak jklymak merged commit 7ea11b7 into matplotlib:main Oct 10, 2023
@QuLogic QuLogic added this to the v3.9.0 milestone Oct 11, 2023
@kots14 kots14 deleted the axes-plot_date-unit-test-for-issue-26864 branch October 14, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

5 participants