Update axislines.py #27079
Closed
Update axislines.py #27079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed _api.warn_deprecated("3.7", message="x=None is deprecated") and Replaced with raise ValueError("x=None is not supported")
ksunden
requested changes
Oct 14, 2023
| _api.warn_deprecated( | ||
| "3.7", message=f"{loc=!r} is incompatible with " | ||
| "{nth_coord=}; support is deprecated since %(since)s") | ||
| raise ValueError("x=None is not supported") |
There was a problem hiding this comment.
Where did this error message come from? It seems unrelated to the checks that are guarding it, what is x?
I think the message should likely be f"{loc=!r} is incompatible with {nth_coord=}"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed _api.warn_deprecated("3.7", message="x=None is deprecated") and Replaced with raise ValueError("x=None is not supported")
PR summary
This PR, titled "Title of Your PR," addresses issue #26962. It [briefly describe why the change is necessary and what problem it solves]. It includes [summarize the main changes made in this PR].
PR checklist