Added smoke test for Axes.stem#27135
Conversation
|
I see that I need to reformat the code, but I was wondering if the test case handles the required task as this is one of my first PRs |
ksunden
left a comment
There was a problem hiding this comment.
Please add a bottom argument to avoid the implicit 1970-01-01 of this method (and exercise that part of the code) (There is also a chance this is broken already, so if it is, that should be reported)
Also please test both vertical and horizontal orientations, as we want to make sure we don't miss that from this method.
|
Probably should set some of the dates to be below |
|
Here is also the updated figure. Sorry if there are still some mistakes but if there are any other changes that need to be made I will make those as well! |
0taj
left a comment
There was a problem hiding this comment.
The changes have been fixed
| fig, (ax1, ax2, ax3, ax4, ax5, ax6) = plt.subplots(6, 1, layout="constrained") | ||
|
|
||
| limit_value = 10 | ||
| above = datetime.datetime(2100, 10, 18) |
There was a problem hiding this comment.
Should the value of these dates be changed?
There was a problem hiding this comment.
I think so, I think so, the far off dates obscure what is actually being plotted, in my opinion
|
Here is the plot with the updated dates |
QuLogic
left a comment
There was a problem hiding this comment.
Sorry for the delay coming back to this.
PR summary
Smoke test for
Axes.stemusing datetime data inlib/matplotlib/tests/test_datetime.py. This PR addresses one of the tasks listed in #26864The image displays the plot of the test case:
PR checklist