added test_axhspan in test_datetime.py#27139
Merged
ksunden merged 3 commits intomatplotlib:mainfrom Oct 20, 2023
danielcobej:add_test_axhspan
Merged
added test_axhspan in test_datetime.py#27139ksunden merged 3 commits intomatplotlib:mainfrom danielcobej:add_test_axhspan
ksunden merged 3 commits intomatplotlib:mainfrom
danielcobej:add_test_axhspan
Conversation
ksunden
requested changes
Oct 18, 2023
Member
ksunden
left a comment
There was a problem hiding this comment.
Neither of the axes have units on the y axis, which is the one that matters for axhspan. As such, no datetime values are being passed to the function we are trying to test.
Contributor
Author
Sorry, it should be fixed now. |
Member
|
Can you provide a new image that is produced? |
Contributor
Author
Yes, just changed the old one in PR summary. |
ksunden
approved these changes
Oct 18, 2023
64 tasks
5 tasks
scottshambaugh
approved these changes
Oct 20, 2023
ksunden
approved these changes
Oct 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I´ve added code for
test_axhspanmethod intest_datetime.pymentioned in issue #26864Image output: (edited)
PR summary
PR checklist