Add test_hlines to test_datetimes.py#27211
Conversation
ksunden
left a comment
There was a problem hiding this comment.
I think we also wish to test the xmin/xmax as dates here
|
Thank you for noting that, I did not think to check This is what the plot generated by this example code looks like: |
|
I added singular float arguments for xmin/xmax - I think that might be why one of the CodeCov checks did not pass. Here is what the new plot looks like: |
|
@ksunden @scottshambaugh could I please have some advice on why the codecov/project/tests check is not passing? It's at 98.76% "compared to a589856" - I don't know why it's comparing this to the test for scatter. |
|
If anybody is having the same issue, I think it stemmed simply from the fact that my branch was not current with the main body of work. Synchronizing it fixed the issue. |
PR summary
I have added a datetime smoketest for
Axes.hlinestolib/matplotlib/tests/test_datetime.py. This example is very similar toAxes.axhline(#27177) – but to test the entire functionality ofhlines, I have done a combination of datetime.datetime/np.datetime64 arrays with both scalar and arrayxmin/xmaxarguments.Below is an image of the plot generated from this example code.
This addresses the
Axes.hlinestask from #26864.PR checklist