Use int.from_bytes instead of implementing the conversion ourselves. #27288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
int.from_bytes has been around since Python 3.2.
story645
approved these changes
Nov 8, 2023
story645
reviewed
Nov 8, 2023
| for b in buf[1:]: | ||
| value = 0x100*value + b | ||
| return value | ||
| return int.from_bytes(self.file.read(nbytes), "big", signed=signed) |
There was a problem hiding this comment.
Should the file pointer be wrapped in a with statement, or does it get cleaned up in the function?
There was a problem hiding this comment.
Its lifetime is managed by the Dvi object.
ksunden
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
int.from_bytes has been around since Python 3.2.
PR summary
PR checklist