-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
DOC: clarify stackplot limits #27335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When the label has |
I'm also not clear on the motivation here. The original example was correct. |
Yes the original example was correct, but it was unclear because the 1e6 multiplication was implicit and most of these numbers are in the billions. Was motivated to open this PR b/c I was showing this example in a seminar and was tripping over the yaxis. |
Since the y-label states it's in millions I would not say it's implicit. However, I think if I were plotting these sorts of magnitudes then I would go the other way: divide by 1000 and change the y-label to say "billions". Would that make it less of a trip hazard? |
Agree w. you that I think framing in billions is the cleanest here as it's the 7 thousand million that's causing me to do a double take. |
converting back to draft because the decimal points aren't being displayed 🤦♀️ |
You could set a custom formatter. However, it is extremely common to specify values in millions (eg, quickly found example - https://www.apple.com/newsroom/pdfs/fy2023-q4/FY23_Q4_Consolidated_Financial_Statements.pdf). I am still not clear on the advantage of this change. |
My two cents:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the plot looks better this way (as I said, it’s what I would do). “five billion” feels more natural to me than “five thousand million”. I also think the plot looks less cluttered without all the zeros in the y tick labels.
Will hold off from merging as there are clearly differing opinions here.
[cross post with @StefRe]
Co-authored-by: Ruth Comer <[email protected]>
Yes but you still want to get a sense of proportion and I think minor ticks help w/ grounding, but also changed the minor ticks to .2 to loosen it a bit & the upside is then it more or less lines up w/ the Africa count (which side note, fixed the capitalization). |
Yes and no - the reason I opened this PR was b/c I was talking about this chart in a seminar (as an example of how the same chart can have different names - stackplot and area chart) and the labeling distracted from the discussion b/c it's a bit clunky. |
Since no-one objects strongly enough to block, and @story645 has clearly explained the motivation for the change, I am going to go ahead and merge. |
People also write things like "10,000 MWh per day", so, yeah, unit handling isn't what it used to be. |
😢 |
PR summary
Y axis says it's million but numbers are in thousands, so trying to make y-axis show a million. (demo for a how to contribute talk)
PR checklist